[depre] Deprecate StaticCallOnNonStaticToInstanceCallRector, as risky change

config/set/php70.php

@@ -16,7 +16,6 @@
 use Rector\Php70\Rector\If_\IfToSpaceshipRector;
 use Rector\Php70\Rector\List_\EmptyListRector;
 use Rector\Php70\Rector\MethodCall\ThisCallOnStaticMethodToStaticCallRector;
-use Rector\Php70\Rector\StaticCall\StaticCallOnNonStaticToInstanceCallRector;
 use Rector\Php70\Rector\StmtsAwareInterface\IfIssetToCoalescingRector;
 use Rector\Php70\Rector\Switch_\ReduceMultipleDefaultSwitchRector;
 use Rector\Php70\Rector\Ternary\TernaryToNullCoalescingRector;
@@ -32,15 +31,13 @@
         MultiDirnameRector::class,
         ListSplitStringRector::class,
         EmptyListRector::class,
-        // be careful, run this just once, since it can keep swapping order back and forth
         ListSwapArrayOrderRector::class,
         CallUserMethodRector::class,
         EregToPregMatchRector::class,
         ReduceMultipleDefaultSwitchRector::class,
         TernaryToSpaceshipRector::class,
         WrapVariableVariableNameInCurlyBracesRector::class,
         IfToSpaceshipRector::class,
-        StaticCallOnNonStaticToInstanceCallRector::class,
         ThisCallOnStaticMethodToStaticCallRector::class,
         BreakNotInLoopOrSwitchToReturnRector::class,
         RenameMktimeWithoutArgsToTimeRector::class,

phpstan.neon

@@ -415,8 +415,10 @@ parameters:
         - '#Rule Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector must implements Rector\\VersionBonding\\Contract\\MinPhpVersionInterface#'
         - '#Register "Rector\\Php81\\Rector\\Array_\\FirstClassCallableRector" service to "php81\.php" config set#'
         - '#Register "Rector\\Php81\\Rector\\ClassMethod\\NewInInitializerRector" service to "php81\.php" config set#'
+        - '#Register "Rector\\Php70\\Rector\\StaticCall\\StaticCallOnNonStaticToInstanceCallRector" service to "php70\.php" config set#'
         - '#Class "Rector\\CodingStyle\\Rector\\String_\\SymplifyQuoteEscapeRector" is missing @see annotation with test case class reference#'
         - '#Class "Rector\\Php81\\Rector\\ClassMethod\\NewInInitializerRector" is missing @see annotation with test case class reference#'
+        - '#Class "Rector\\Php70\\Rector\\StaticCall\\StaticCallOnNonStaticToInstanceCallRector" is missing @see annotation with test case class reference#'
         - '#Class "Rector\\TypeDeclaration\\Rector\\ClassMethod\\StrictStringParamConcatRector" is missing @see annotation with test case class reference#'
 
         # false positive

rules-tests/Php70/Rector/Assign/ListSwapArrayOrderRector/Fixture/skip_already_array_reverse.php.inc

@@ -0,0 +1,11 @@
+<?php
+
+namespace Rector\Tests\Php70\Rector\Assign\ListSwapArrayOrderRector\Fixture;
+
+class SkipAlreadyArrayReverse
+{
+    public function a()
+    {
+        list($a[], $a[]) = array_reverse([1, 2]);
+    }
+}