Skip to content

[DeadCode] Skip RemoveDoubleAssignRector when assign target contains a side-effecting call #8110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TomasVotruba merged 1 commit into from
Jun 29, 2026
+22 −0
Merged

[DeadCode] Skip RemoveDoubleAssignRector when assign target contains a side-effecting call #8110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions ...eadCode/Rector/Assign/RemoveDoubleAssignRector/Fixture/skip_call_in_assign_target.php.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
<?php

namespace Rector\Tests\DeadCode\Rector\Assign\RemoveDoubleAssignRector\Fixture;

final class SkipCallInAssignTarget
{
public function run($container)
{
$container->get(SomeService::class)->enabled = true;
$container->get(SomeService::class)->enabled = true;
$container->get(SomeService::class)->enabled = true;
}
}
9 changes: 9 additions & 0 deletions rules/DeadCode/Rector/Assign/RemoveDoubleAssignRector.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,6 +100,15 @@ public function refactor(Node $node): ?Node
continue;
}

// the assignment target itself may contain a call with side effects,
// e.g. $object->getService()->property = 1; — removing the first assign would skip the call
if ($this->betterNodeFinder->findFirst(
$stmt->expr->var,
fn (Node $subNode): bool => $this->sideEffectNodeDetector->detectCallExpr($subNode)
) instanceof Node) {
continue;
}

// next stmts can have side effect as well
if (($nextAssign->var instanceof PropertyFetch || $nextAssign->var instanceof StaticPropertyFetch) && $this->sideEffectNodeDetector->detectCallExpr(
$nextAssign->expr
Expand Down
Loading