[CodeQuality] Add SwitchTrueToMatchRector as replacement for deprecated SwitchTrueToIfRector#8113
Merged
Merged
Conversation
…ed SwitchTrueToIfRector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the deprecated
SwitchTrueToIfRectorwithSwitchTrueToMatchRector.Instead of expanding a compact
switch (true)into manyifstatements, it converts it into a singlematch (true)expression.class SomeClass { public function run($value) { - switch (true) { - case $value === 0: - return 'no'; - case $value === 1: - return 'yes'; - default: - return 'maybe'; - } + return match (true) { + $value === 0 => 'no', + $value === 1 => 'yes', + default => 'maybe', + }; } }Scope / safety
switch (true).return <expr>;(amatcharm is one expression).defaultcase, and it must be the last one. This avoids a behavior change: amatch (true)with no matching arm throwsUnhandledMatchError, whereasswitch (true)falls through.CodeQualityLevel.Cases with
break, assignments, or no/non-trailingdefaultare skipped.Replaces the rule deprecated in #8109.