fix: Update AppSet Icon (#10078)

[keithchong]

See GITOPS-10078

[coderabbitai]

Warning

Review limit reached

@keithchong, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 36 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 9026c1e5-57e8-409c-b33c-08606ca86baa

📥 Commits

Reviewing files that changed from the base of the PR and between ba284ea and def3900.

⛔ Files ignored due to path filters (1)

• src/images/resources/applicationset.svg is excluded by !**/*.svg

📒 Files selected for processing (1)

• src/gitops/components/appset/graph/nodes/ApplicationSetNode.tsx

📝 Walkthrough

Walkthrough

ApplicationSetNode replaces its inline SVG brace foreignObject elements and ApplicationIcon render with a single ApplicationSetIcon component, setting its fill to the node stroke color. The ApplicationIcon import is removed and ApplicationSetIcon is imported instead.

Changes

ApplicationSetNode Icon Replacement

Layer / File(s)	Summary
Swap inline icon composition for ApplicationSetIcon src/gitops/components/appset/graph/nodes/ApplicationSetNode.tsx	Removes ApplicationIcon import and the inline brace foreignObject elements; adds ApplicationSetIcon import and renders it as the sole shape content with stroke-based fill styling.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: updating the AppSet icon in the ApplicationSetNode component.
Description check	✅ Passed	The description is minimal but directly related to the changeset, referencing the specific ticket that drives this icon update.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[codecov-commenter]

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (main@cdadfac). Learn more about missing BASE report.

Files with missing lines	Patch %	Lines
...mponents/appset/graph/nodes/ApplicationSetNode.tsx	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #249   +/-   ##
=======================================
  Coverage        ?   11.80%           
=======================================
  Files           ?      154           
  Lines           ?     6344           
  Branches        ?     2175           
=======================================
  Hits            ?      749           
  Misses          ?     5595           
  Partials        ?        0           

Flag	Coverage Δ
unit-tests	11.80% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/gitops/components/appset/graph/nodes/ApplicationSetNode.tsx`:
- Line 105: The ApplicationSetIcon component is using the fill style property to
set its color, but the SVG path inside is defined with fill="currentColor",
which means it only responds to the CSS color property, not the fill property.
To fix this, either modify the SVG file to use a regular fill color instead of
currentColor, or update the ApplicationSetIcon component usage to pass style={{
color: 'var(--pf-topology__node__background--Stroke)' }} instead of using the
fill property. The key is to align the style property with what the SVG actually
respects - use color property when the SVG uses currentColor.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Enterprise

Run ID: 5ae22986-7a5a-40bf-b0a7-2ee9a9ee577d

📥 Commits

Reviewing files that changed from the base of the PR and between cdadfac and ba284ea.

⛔ Files ignored due to path filters (1)

• src/images/resources/applicationset.svg is excluded by !**/*.svg

📒 Files selected for processing (1)

• src/gitops/components/appset/graph/nodes/ApplicationSetNode.tsx

[aali309]

LGTM, Thanks @keithchong