test(scho oss): add smigrating checks for new connections#3186
Merged
nkaradzhov merged 1 commit intoredis:masterfrom Feb 25, 2026
Merged
test(scho oss): add smigrating checks for new connections#3186nkaradzhov merged 1 commit intoredis:masterfrom
nkaradzhov merged 1 commit intoredis:masterfrom
Conversation
PavelPashov
approved these changes
Feb 25, 2026
| }); | ||
|
|
||
| diagnostics_channel.subscribe("redis.maintenance", onEvent); | ||
| setTimeout(timeout, () => finish(false)); |
Contributor
There was a problem hiding this comment.
Should this setTimeout be awaited?
Collaborator
Author
There was a problem hiding this comment.
no, this is basically an abort signal that we run in the background.
| const event = message as DiagnosticsEvent; | ||
| if (event.type !== "SMIGRATING") return; | ||
|
|
||
| received++; |
Contributor
There was a problem hiding this comment.
With a counter, one client could end up receiving 2 events while another receives none.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Checklist
npm testpass with this change (including linting)?