Skip to content

ENG-9742: Update mobile drawer menu for web#6642

Open
carlosabadia wants to merge 5 commits into
mainfrom
carlos/update-mobile-drawer
Open

ENG-9742: Update mobile drawer menu for web#6642
carlosabadia wants to merge 5 commits into
mainfrom
carlos/update-mobile-drawer

Conversation

@carlosabadia

Copy link
Copy Markdown
Contributor

No description provided.

@carlosabadia carlosabadia requested a review from Alek99 as a code owner June 10, 2026 09:20
@carlosabadia carlosabadia added the skip-changelog For doc/internal changes label Jun 10, 2026
@carlosabadia carlosabadia requested a review from a team as a code owner June 10, 2026 09:20
@linear-code

linear-code Bot commented Jun 10, 2026

Copy link
Copy Markdown

ENG-9742

@codspeed-hq

codspeed-hq Bot commented Jun 10, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 26 untouched benchmarks
⏩ 8 skipped benchmarks1


Comparing carlos/update-mobile-drawer (06a8843) with main (7562344)

Open in CodSpeed

Footnotes

  1. 8 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

@greptile-apps

greptile-apps Bot commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Replaces the simple flat mobile drawer menu (docs app + shared package) with a rich structured drawer shared across both sites. The docs app's sidebar.py is trimmed to a re-export, eliminating ~155 lines of duplication.

  • New shared drawer: collapsible sections for Products, Resources, and Solutions, non-collapsible links for Enterprise / Pricing / Docs, and a Sign-In footer; navbar_sidebar_button switches from rx.box to rx.el.div.
  • docs_sidebar_drawer fixed: inner container now carries flex-1 min-h-0 and the outer content uses an explicit h-[calc(100dvh-4rem)] min-h-0, correcting the prior overflow-scroll regression.
  • cta_card background: bg-secondary-1/96 replaced with bg-white-1; new feather_pen icon added to the shared icon registry.

Confidence Score: 5/5

Safe to merge — changes are isolated to UI layout and styling with no backend, state, or data-flow impact.

The rewrite consolidates duplicated drawer logic correctly, the flex/overflow fixes in docs_sidebar_drawer are improvements over the prior state, and the bun.lock bump is a routine dependency update. The only finding is the missing external=True on the Changelog link, which is a cosmetic/UX inconsistency.

No files require special attention beyond the CHANGELOG_URL call site in sidebar/__init__.py.

Important Files Changed

Filename Overview
packages/reflex-site-shared/src/reflex_site_shared/views/sidebar/init.py Complete rewrite of the mobile/web drawer menu: old flat list replaced with collapsible Products/Resources/Solutions structure plus a Sign-In footer. docs_sidebar_drawer gains flex-1 min-h-0 on the inner container and explicit h-[calc(100dvh-4rem)] on the content. Minor: CHANGELOG_URL missing external=True.
docs/app/reflex_docs/components/docpage/navbar/buttons/sidebar.py Reduced from ~160 lines of duplicated drawer logic to a 5-line re-export of docs_sidebar_drawer and navbar_sidebar_button from the shared package.
packages/reflex-site-shared/src/reflex_site_shared/components/icons.py Added feather_pen SVG icon and registered it in the ICONS dict for use in the Solutions panel's 'Read customer stories' row.
packages/reflex-site-shared/src/reflex_site_shared/views/cta_card.py Single-line background color change: bg-secondary-1/96 replaced with bg-white-1.
docs/app/reflex.lock/bun.lock Lock file updated to reflect bumped @radix-ui/* package versions — no logic changes.

Reviews (4): Last reviewed commit: "update offset" | Re-trigger Greptile

@masenf

masenf commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

the docs sidebar for the open source / ai / enterprise sections still has the scrolling issue on mobile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip-changelog For doc/internal changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants