Skip to content

fix(editor): disable link open on click#3081

Merged
gabrielmfern merged 1 commit intofeat/ai-oss-editorfrom
joaopcm/fix-editor-link-click
Mar 18, 2026
Merged

fix(editor): disable link open on click#3081
gabrielmfern merged 1 commit intofeat/ai-oss-editorfrom
joaopcm/fix-editor-link-click

Conversation

@joaopcm
Copy link
Member

@joaopcm joaopcm commented Mar 18, 2026

Summary

Disables the default openOnClick behavior in the TipTap Link extension. By default, clicking a link in the editor navigates to it, which is disruptive during editing. Setting openOnClick: false prevents accidental navigation when users intend to select or edit a link.

Testing steps

  • Open the editor and insert a hyperlink
  • Click on the link — verify it does NOT navigate/open the URL
  • Verify the link can still be selected and edited normally
  • Verify that link rendering and styling are unaffected

Summary by cubic

Disable link navigation on click in the editor by setting the TipTap Link extension to openOnClick: false, so clicks don’t navigate away while editing. Bumps @react-email/editor to 0.0.0-experimental.29.

Written for commit fe89e36. Summary will update on new commits.

@changeset-bot
Copy link

changeset-bot bot commented Mar 18, 2026

⚠️ No Changeset found

Latest commit: fe89e36

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link
Contributor

vercel bot commented Mar 18, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
react-email Ready Ready Preview, Comment Mar 18, 2026 5:37pm
react-email-demo Ready Ready Preview, Comment Mar 18, 2026 5:37pm

Request Review

@socket-security
Copy link

socket-security bot commented Mar 18, 2026

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License
Addedesbuild@​0.27.3911007392100
Addedhappy-dom@​20.8.3751008896100
Addedflamebearer@​1.1.3891007775100
Addedhtml-to-ast@​0.0.6831009980100
Addedhast-util-from-html@​2.0.39910010081100
Addedhtml-to-text@​9.0.59910010082100
Addedfs-extra@​11.3.410010010089100
Addedglob@​13.0.6951009992100
Addedframer-motion@​12.23.2295100100100100

View full report

@socket-security
Copy link

socket-security bot commented Mar 18, 2026

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

Ignoring alerts on:

  • esbuild@0.27.3

View full report

@joaopcm joaopcm requested a review from gabrielmfern March 18, 2026 17:37
@pkg-pr-new
Copy link

pkg-pr-new bot commented Mar 18, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@react-email/editor@3081

commit: f77ff14

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 2 files

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

@gabrielmfern
Copy link
Member

@SocketSecurity ignore npm/esbuild@0.27.3

@gabrielmfern gabrielmfern merged commit b08247e into feat/ai-oss-editor Mar 18, 2026
16 of 17 checks passed
@gabrielmfern gabrielmfern deleted the joaopcm/fix-editor-link-click branch March 18, 2026 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants