Skip to content

Add IPv6 to supported dump target#146

Open
coiby wants to merge 1 commit intorhkdump:mainfrom
coiby:ipv6_target_doc
Open

Add IPv6 to supported dump target#146
coiby wants to merge 1 commit intorhkdump:mainfrom
coiby:ipv6_target_doc

Conversation

@coiby
Copy link
Member

@coiby coiby commented Mar 2, 2026

Resolves: https://issues.redhat.com/browse/RHEL-83890

IPv6 has already been supported. Also use upper case names.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the documentation for supported kdump targets to accurately reflect that IPv6 is a supported network protocol. The change clarifies the existing support for IPv6, ensuring the documentation aligns with current capabilities and uses consistent uppercase naming for protocols.

Highlights

  • Documentation Update: Updated the supported-kdump-targets.txt file to explicitly include IPv6 as a supported network protocol for kdump targets, aligning documentation with existing functionality.
  • Protocol Naming Convention: Standardized the naming convention for network protocols to use uppercase (e.g., 'IPv4', 'IPv6') within the documentation.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • supported-kdump-targets.txt
    • Updated the 'protocol' entry under 'network' to include 'IPv6' alongside 'IPv4'.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation to reflect that IPv6 is a supported protocol for network kdump targets and standardizes the casing for protocol names. However, the change is incomplete as it doesn't remove IPv6 from the list of unsupported targets, creating a contradiction in the documentation. Please see the specific comment for details.

Resolves: https://issues.redhat.com/browse/RHEL-83890

IPv6 has already been supported. Also use upper case names.

Signed-off-by: Coiby Xu <coxu@redhat.com>
@coiby coiby force-pushed the ipv6_target_doc branch from 968d7c7 to 0304133 Compare March 2, 2026 09:33
@coiby
Copy link
Member Author

coiby commented Mar 3, 2026

For the failure of tests on CoreOS, it's not caused by the PR and I've filed coreos/fedora-coreos-tracker#2116

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant