Conversation
| bool intervals_check_unclosed = 15; | ||
| // AI report configuration | ||
| string format = 17; // "query" (default) or "ai_session" | ||
| AIReportConfig ai_config = 18; // Configuration for AI-powered reports (only used when format = "ai_session") |
There was a problem hiding this comment.
If you look at alerts, they have generic resolver and resolver_properties fields:
rill/proto/rill/admin/v1/api.proto
Lines 3340 to 3345 in fd7a010
rill/proto/rill/runtime/v1/resources.proto
Lines 649 to 650 in fd7a010
We also intended to do the same for reports, but we never got around to it. However, with this change, rather than hard-code the AI resolver properties here, can we take a generic approach similar to alerts?
There was a problem hiding this comment.
made the change for ai report, need to fix the export request and download api for standard report
| // AITimeRange defines a time range using ISO 8601 duration strings. | ||
| // The time range is resolved at report execution time. | ||
| message AITimeRange { | ||
| string iso_duration = 1; // ISO 8601 duration (e.g., "P7D" for 7 days, "P1M" for 1 month) | ||
| string iso_offset = 2; // Optional ISO 8601 offset for comparison ranges (e.g., "P7D" to offset by 7 days) | ||
| string time_zone = 3; // IANA timezone (e.g., "America/New_York") | ||
| } |
There was a problem hiding this comment.
This appears not to support Rill time expressions? I believe the UI only uses those for new reports (or otherwise, they will probably migrate to that soon).
Instead of a custom type, can it use our main TimeRange proto type, which we already have utils for converting into a concrete time range? Thinking about this one:
rill/proto/rill/runtime/v1/queries.proto
Lines 610 to 627 in fd7a010
There was a problem hiding this comment.
Aa far as I remember, at the time of coding UI was not using expressions so used this, related to this during tool calls LLM would most of the times use expressions in wrong way like adding other fields along with it, causing validation errors. Was not aware its the way going forward, I can make that change and possibly add some concrete examples with expression so that it uses them correctly
There was a problem hiding this comment.
This would always lead to failed tool calls thus wasting tokens
runtime/ai/analyst_agent.go
Outdated
| // Add scheduled insight mode context | ||
| data["is_scheduled_insight"] = args.IsScheduledInsight | ||
| data["is_scheduled_insight_user_prompt"] = args.IsScheduledInsight && !(strings.EqualFold(strings.TrimSpace(args.Prompt), "Generate the scheduled insight report.")) |
There was a problem hiding this comment.
- Doing a
strings.EqualFoldseems kind of unsafe in case we change that text upstream. Would it be possible to keep the prompt empty (so we can doif eq .prompt ""), and inject the "Generate ..." prompt inuserPromptwhen prompt is empty andIsScheduledInsightis true? - Nit: Can you move this up to the initial
data :=statement like the other props?
There was a problem hiding this comment.
Adding a custom flag to indicate if user has provided custom prompt. The reason for not injecting userPrompt is because it won't be visible in session messages then, if we want in session msgs then we will have add router and agent call msgs along with their full json args.
It won't matter much anyways as per discussion with Nishant, we would always want a prompt here so I think as user keep on selecting time period, measures and dims in the report modal, UI can dynamically create prompt like it does for Explain feature - prompt can be like this for comparative analysis
You are doing comparative analysis between two time periods <t1, t2> in scheduled insight report mode, your analysis should:
1. Compare current period to the comparison period for <all key> or <m1, m2...> measures
2. Identify which measures changed significantly (>10%)
3. For each significant change, identify the dimensional drivers
4. Highlight any ranking changes in top dimensions
5. Generate 3-5 key insights with supporting charts
Focus areas:
- **Overall changes**: Which measures changed the most between periods?
- **Drivers of change**: Which dimensions contributed most to increases/decreases?
- **Ranking shifts**: Did any top dimensions change rank significantly?
- **Anomalies**: Any unusual patterns unique to one period?
For single period analysis -
You are doing analysis on time period <t1> in scheduled insight report mode, your analysis should:
1. Show totals for the <most impactful> or <m1, m2...> measures in the period
2. Identify interesting trends within the time range (use time series)
3. Find anomalies - unusual spikes, drops, or outliers
4. Highlight top performers and notable dimension values
5. Generate 3-5 key insights with supporting charts
Focus areas:
- **Totals**: What are the key numbers for this period?
- **Trends**: How did metrics change over the period? Any acceleration/deceleration?
- **Anomalies**: Are there any unusual data points that stand out?
- **Distribution**: Which dimensions dominate? Any concentration issues?
| func buildAISessionURL(baseOpenURL, sessionID string) string { | ||
| // replace {session_id} in the baseOpenURL with the actual sessionID | ||
| return strings.ReplaceAll(baseOpenURL, "%7Bsession_id%7D", sessionID) | ||
| } |
There was a problem hiding this comment.
This feels a little hacky, had to jump back to the URL generation to check things here. Would be nice at least with a comment about this feature in the URLs generation function.
But also, I'm thinking if there's a way we can make this a bit more generic/clean. Another thing we need to support soon is precomputed report exports. Which is kind of similar to a pre-created AI session. I wonder if thinking about that use case as well could give us a cleaner path here.
For example, in alerts, we store the alert history in AlertState. Maybe we should keep similar history for reports? And then keep the existing reports/{name}/open link and let the UI redirect? Not sure.
There was a problem hiding this comment.
Added a comment at url generation place. You meant to store resolver and its corresponding meta id like session id in case of ai session in ReportExecution proto?
There was a problem hiding this comment.
Yes that's what I was wondering, e.g. being able to have a "delivery ID" and open a report like /-/reports/{name}/delivery/{delivery ID}/open. But I think it may not be a simple refactor, so probably not worth it now given that injecting ai_session_id into the URL params on the runtime as we discussed is already pretty clean.
admin/server/reports.go
Outdated
| if webOpenMode == WebOpenModeRecipient || req.Resolver == "ai" { | ||
| // in recipient mode tokens are used for unsubscribing and for ai reports, shared sessions are created so token is just used for authentication, so no access to resources is needed | ||
| tokens, err = s.createMagicTokensWithoutResources(ctx, proj.ID, req.Report, req.OwnerId, recipients) |
There was a problem hiding this comment.
Does it matter about the resources? Like if it had resource access to the report, would it be a problem? Basically, it would be nice to keep it generic and avoid custom checks like req.Resolver == "ai" if possible.
If the checks cannot be avoided, can it then pass the report format instead of the resolver? (And maybe use a proto enum for the report format.) Since the goal of resolvers is to keep them generic.
There was a problem hiding this comment.
Yeah it should not matter if they get access to report, resolving transitive access with ai resolver is not supported so added this check. But you are correct, we can simplify this and I can return nil from InferRequiredSecurityRules of ai resolver for now (meaning no access) as we cannot directly know the referred metrics views and accessible fields without going through get_metrics_view tool call results, can be done probably in a follow up.
admin/server/reports.go
Outdated
| // Handle resolver-based reports (new style) vs legacy query-based reports | ||
| if opts.Resolver != "" && opts.ResolverProperties != nil { | ||
| res.Data = map[string]any{ | ||
| opts.Resolver: opts.ResolverProperties.AsMap(), | ||
| } | ||
| } else { | ||
| // Legacy query-based report | ||
| res.Query.Name = opts.QueryName | ||
| res.Query.ArgsJSON = opts.QueryArgsJson | ||
| res.Export.Format = opts.ExportFormat.String() | ||
| res.Export.IncludeHeader = opts.ExportIncludeHeader | ||
| res.Export.Limit = uint(opts.ExportLimit) | ||
| } |
There was a problem hiding this comment.
Shouldn't the res.Export fields be set in both cases? Like if you pass resolver: metrics, then the export fields are still relevant.
There was a problem hiding this comment.
Yes I was imagining resolver support for only ai session for now and add support generally in later version but its causing complexity and confusion. Will fix this.
There was a problem hiding this comment.
Just noticed that metrics resolver has ResolveExport unimplemented, may be its a miss? also its not parsed in parse_partial_data.go
There was a problem hiding this comment.
ResolveExport is not currently used anywhere, but was intended to replace the current hard-coded exports (see the ugly switch in downloadHandler). The alerts use resolvers, but they don't use exports, only queries. And since reports and UI downloads haven't migrated to resolvers yet, there probably hasn't been a reason to implement it before. It would be great to implement it, and to migrate reports over to resolvers fully.
runtime/resolvers/ai.go
Outdated
|
|
||
| // if metrics view is provided, we can get the metrics view's time bounds | ||
| if r.metricsView != "" { | ||
| mv, security, err := queries.ResolveMVAndSecurityFromAttributes(ctx, r.runtime, r.instanceID, r.metricsView, r.claims) |
There was a problem hiding this comment.
Consider inlining this function. We're trying to deprecate the runtime/queries package in favor of runtime/resolvers, so dependencies like this make it more complicated.
There was a problem hiding this comment.
I see that its also available in server package so exporting that and using it.
There was a problem hiding this comment.
I'm not sure this is a good idea from an abstractions perspective. The the server/API layer is logically the "outermost" layer, so inner service layers should not import from that.
If you want to have it in a central place, it should probably be as a member function on runtime.Runtime.
There was a problem hiding this comment.
So seems like in server package, its only used in the downloadHandler, after moving to resolvers, that will get removed anyways so inlined the function in this file only.
| // Generic resolver configuration (preferred for new reports) | ||
| string resolver = 17; |
There was a problem hiding this comment.
As a general reflection, I think the removal of the query|ai_session format has made some things more complicated, and made it more difficult to support Markdown reports.
It's okay to have some custom logic like resolver == "ai" in one or two specific places if needed, ideally inside the report reconciler itself, but to have it spread out in many packages feels like a problem. Then it's better to have some structured/typed option, such as a report_type enum or something like that.
On reconciliation, an AI resolver is created which generates an AI session with
analyst_agentand a slightly modified system prompt for scheduled report, upon competition it include a summary and send out the session id link to the recipient.Report modes behaviour
Recipient mode - In this mode, AI report is run with each recipient attributes and a separate session is created for them.
Creator mode - In this mode, a single session is created with owners attribute (without any charts as it required mv agg for rendering), this session is a shared session and a magic token is used for viewing this session (this mgc token has no access just used for authentication), for continuing conversation user should be logged in and conversation should be forked.
Format
Reports can now use
format: ai_sessionto generate AI-powered insights instead of traditional query exports. Example YAML:Checklist: