fix sandbox networking loopback dev servers#101
Merged
Conversation
|
🚅 Environment secure-exec-pr-101 in rivet-frontend has no services deployed. |
9db9387 to
40339af
Compare
526484d to
7772279
Compare
7772279 to
69466cd
Compare
NathanFlurry
added a commit
that referenced
this pull request
Jun 20, 2026
NathanFlurry
added a commit
that referenced
this pull request
Jun 20, 2026
…chmarks #101/#102 renamed the core class Sidecar to SidecarProcess but left the public `secure-exec` umbrella re-export and the benchmarks helper importing the old name, breaking `turbo build` (TS2305: no exported member 'Sidecar'). Examples are excluded from the publish build so are left as-is. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
http.createServer()onto the kernel TCP listener path by accepting realnet.Serversockets and dispatching HTTP over bytes.vmFetch/runtime.fetch()to VM-owned kernel TCP listeners before falling back to the legacy object-mode HTTP path.Transfer-Encoding: chunkedresponses in the Rust host-fetch parser and rejects invalidTransfer-Encoding: chunkedplusContent-Lengthresponses.ServerResponseBridgeresponses that useres.write()as streamed, then serializes them as HTTP/1.1 chunked responses when no explicitContent-Lengthis present.OnceLockinstead of parsing env on every request.http_serverC fixture and expands the cross-runtime matrix to HTTP and raw TCP rows.docs/testing/networking-bridge-spec.mdwith the long-term architecture and audit matrix.Validation
cargo test -p secure-exec-sidecar http_socket_backed_server --test service -- --nocapture --test-threads=1cargo test -p secure-exec-sidecar vm_fetch_ --test service -- --nocapture --test-threads=1cargo test -p secure-exec-sidecar javascript_fetch_reaches_http_server_in_parallel_guest_process --test service -- --nocapture --test-threads=1rustfmt --edition 2021 --check crates/sidecar/src/execution.rs crates/sidecar/tests/service.rspnpm --dir registry exec vitest run tests/kernel/cross-runtime-network.test.tsSECURE_EXEC_WASM_COMMANDS_DIR=/home/nathan/secure-exec/packages/core/commands SECURE_EXEC_C_WASM_COMMANDS_DIR=/tmp/secure-exec-network-fixtures pnpm --dir registry exec vitest run tests/kernel/cross-runtime-network.test.tsSECURE_EXEC_WASM_COMMANDS_DIR=/tmp/secure-exec-missing-wasm SECURE_EXEC_C_WASM_COMMANDS_DIR=/tmp/secure-exec-missing-c pnpm --dir registry exec vitest run tests/kernel/cross-runtime-network.test.tsSECURE_EXEC_WASM_COMMANDS_DIR=/home/nathan/secure-exec/packages/core/commands pnpm --dir examples/docs/feat-networking startSECURE_EXEC_WASM_COMMANDS_DIR=/home/nathan/secure-exec/packages/core/commands SECURE_EXEC_C_WASM_COMMANDS_DIR=/tmp/secure-exec-network-fixtures pnpm --dir examples/docs/feat-networking-wasm startSECURE_EXEC_WASM_COMMANDS_DIR=/home/nathan/secure-exec/packages/core/commands pnpm --dir examples/docs/uc-dev-servers startpnpm --dir examples/docs/feat-networking check-typespnpm --dir examples/docs/feat-networking-wasm check-typespnpm --dir examples/docs/uc-dev-servers check-typescc -fsyntax-only registry/native/c/programs/http_server.cpnpm --dir website buildScope notes
DisposeVmduring an active hostVmFetchis not representable in the current single-client, single-NativeSidecarrequest handler. Host-fetch failure cleanup is covered by timeout, malformed response, configured/raw limit rejection, socket-cap rejection, and target-exit cleanup rows.Related issue
Related #88