fix(core): restore Sidecar public export + sidecar-client subpath#112
Open
abcxff wants to merge 1 commit into
Open
fix(core): restore Sidecar public export + sidecar-client subpath#112abcxff wants to merge 1 commit into
abcxff wants to merge 1 commit into
Conversation
…sidecar-client subpath
|
🚅 Deployed to the secure-exec-pr-112 environment in rivet-frontend
🚅 Deployed to the secure-exec-pr-112 environment in secure-exec
|
NathanFlurry
added a commit
that referenced
this pull request
Jun 23, 2026
@secure-exec/core dropped the public `Sidecar` export (the public name for `SidecarProcess`) and the ./sidecar-client subpath still pointed at a non-existent sidecar-client.* file. The `secure-exec` package imports `Sidecar` from @secure-exec/core, so its build failed with TS2305 during publish. Re-export `SidecarProcess as Sidecar` and repoint the subpath to sidecar-process.*. (Mirrors PR #112.) Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
@secure-exec/corewas renamed internally (sidecar-client.ts→sidecar-process.ts, classSidecar→SidecarProcess) but the public surface wasn't updated, so onmain:@secure-exec/coreno longer exportsSidecar(onlySidecarProcess)./sidecar-clientexport still points at the now-nonexistentdist/sidecar-client.js(the source builds todist/sidecar-process.js)Consumers that import
Sidecar/@secure-exec/core/sidecar-client(thesecure-execfacade, thenative-clientexample, and@rivet-dev/agentos-core) fail to build with TS2305 / TS2307.Fix (3 small edits, no consumer changes)
sidecar-process.ts:export { SidecarProcess as Sidecar }index.ts: also exportSidecarfrom the package rootpackage.json: repoint the./sidecar-clientexport to./dist/sidecar-process.{js,d.ts}sidecar-process.tsalready re-exports the full priorsidecar-clientsurface (SidecarProcessError,SidecarProcessExited,SidecarEventBufferOverflow, the types), so the public API is preserved exactly.Verification
With this change,
@secure-exec/corebuilds, thesecure-execfacade builds, and thenative-clientexample typechecks clean.🤖 Generated with Claude Code