[codex] security runtime followups#99
Merged
Merged
Conversation
|
🚅 Environment secure-exec-pr-99 in rivet-frontend has no services deployed. |
342b83f to
f408cfb
Compare
f408cfb to
5c7b16c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Implements the secure-exec security-review followups for the runtime layer:
wait()Why
The post-merge review found that several earlier protections were either default-off or not enforced on the sidecar production path. These gaps left CPU/memory runaways possible and could poison reused V8 isolates after termination.
Validation
pnpm --dir /home/nathan/secure-exec-followups/packages/core buildcargo test -p secure-exec-sidecar defaults_match_struct_default --test limits -- --exact --nocapturecargo test -p secure-exec-v8-runtime embedded_runtime_session_consolidated_behaviors --test embedded_runtime_session -- --exact --nocapturecargo test -p secure-exec-execution wasm_suite --test wasm -- --exact --nocapturecargo test -p secure-exec-sidecar service::tests::aab_wasm_command_timeout_is_enforced_by_sidecar_poll_path --test service -- --exact --nocapturecargo test -p secure-exec-execution javascript_v8_suite --test javascript_v8 -- --exact --nocaptureNotes
The TODO suggested one finding per PR. I grouped the three secure-exec runtime findings here because the tests and behavior overlap in the execution timeout/limit surface; split is possible if preferred.