Feat/nemo rl task5 6 7 rlix progress hooks#5
Open
TianyeGGBond wants to merge 4 commits intorlops:mainfrom
Open
Feat/nemo rl task5 6 7 rlix progress hooks#5TianyeGGBond wants to merge 4 commits intorlops:mainfrom
TianyeGGBond wants to merge 4 commits intorlops:mainfrom
Conversation
Add rlix_hooks.py: RLixHooksProtocol (typing_extensions Protocol) + NoOpRLixHooks default for standalone mode. Seam file keeps NeMo RL free of direct rlix package imports. Modify async_grpo_train: - rlix_hooks parameter injected by NemoRLRLixHooks from pipeline actor - DO_TIME_SHARING flag from RLIX_CONTROL_PLANE env var - before_training(step): blocks on scheduler GPU grant before lp_inference - after_training(step): notifies scheduler release; replaces refit in RLix mode (weight sync + version update done atomically in _expand_workers, F6) - on_trajectory_collector_created: registers collector handle so _expand_workers can call set_weight_version before activating dp rank routing - Initial refit and prepare_for_generation skipped when DO_TIME_SHARING=True TODO placeholders in after_training branch: F4: policy.build_cpu_bucket_cache(step) F11: policy.offload_training_gpu() + policy.destroy_nccl_groups() Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wire RLix Task 5/6/7 hooks into NeMo async GRPO
Summary
This PR wires the NeMo RL side of the RLix Task 5/6/7 integration into async GRPO:
AsyncTrajectoryCollectorRLIX_CONTROL_PLANE=rlixNotes
Feature 11's NCCL offload implementation is intentionally not duplicated here. This branch expects the API from #4:
nemo_rl.models.megatron.nccl_offload.destroy_megatron_nccl_groups()nemo_rl.models.megatron.nccl_offload.reload_megatron_nccl_groups(state_snapshot)Until PR #4 lands or this branch is stacked on it, the
RLIX_CONTROL_PLANE=rlixpath has that dependency. Standalone NeMo RL behavior uses no-op hooks and should remain unchanged.Validation
python -m py_compile nemo_rl/algorithms/async_utils.py nemo_rl/algorithms/grpo.py nemo_rl/algorithms/rlix_hooks.pygit diff --checkCould not run the RL pytest suite locally because this environment is missing
ray.