AsyncDataloader: Rework task waiting#5672
Merged
Merged
Conversation
rmosolgo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying to fix #5671
The previous control flow around paused tasks was very clunky. This PR streamlines it by replacing the
started_andfinished_queues with a single queue that receives status updates from running tasks.As a result, it's very easy to keep a set of currently-running tasks, and then to know when they're done.
This change also makes the
Runitself aware of whether its parent Dataloader still has unscheduled work. This allows me to properly distinguish between two different conditions:Those checks were mixed together previously, leading to ... bugs ..?