Skip to content

[PTBC1: CK] Timer#17

Open
makck wants to merge 4 commits intorocketacademy:mainfrom
makck:main
Open

[PTBC1: CK] Timer#17
makck wants to merge 4 commits intorocketacademy:mainfrom
makck:main

Conversation

@makck
Copy link
Copy Markdown

@makck makck commented Sep 3, 2021

Please fill out the survey before submitting the pull request. Thanks!

🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀🚀

How many hours did you spend on this assignment?

Please fill in one error and/or error message you received while working on this assignment.

What part of the assignment did you spend the most time on?

Comfort Level (1-5):

Completeness Level (1-5):

What did you think of this deliverable?

Is there anything in this code that you feel pleased about?

Copy link
Copy Markdown

@michelle-mok michelle-mok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work on organising your code and using setInterval!
keep up the good work!

userNameInput.remove();
submitButton.remove();
// eslint-disable-next-line no-use-before-define
initGame();
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work calling initGame() after user's name has been entered

resumeButton.classList.add('timer-button');
resumeButton.innerText = 'Start';
resumeButton.addEventListener('click', () => {
isPaused = false;
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding more comments so that it is easier for the reader to follow your code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants