fix(viewer): sort Memories tab newest first (#674)

[rohitg00]

Summary

#674 — viewer Memories tab renders in KV-insertion order, so newly-saved memories appear at the bottom of long lists. Sessions and Metrics tabs already sort startedAt desc via localeCompare; Memories should match.

Changes

• src/viewer/index.html — loadMemories() now sorts items newest-first on createdAt (fallback updatedAt) before storing in state.memories.items. Sort runs once on load, not per render — same pattern the Sessions / Metrics tabs use at viewer:1426 / :2407 / :2420 / :2636. No new deps, no API change.
• test/viewer-memories-sort.test.ts — 3 source-string assertions confirming the sort + fallback + parallel structure with sessions sort.

Test plan

• npx vitest run test/viewer-memories-sort.test.ts — 3/3 pass
• Manual: open viewer with 500+ memories, call memory_save, refresh Memories tab — new entry appears at top.

Closes #674.

Summary by CodeRabbit

• New Features

  • Memory entries in the Memories tab now display with the newest items appearing first.

• Tests

  • Added test coverage for memory sorting functionality.

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
agentmemory	Ready	Preview, Comment	May 28, 2026 10:27am

[coderabbitai]

📝 Walkthrough

Walkthrough

The Memories tab in the viewer now sorts entries newest-first by createdAt (falling back to updatedAt) before storing them in state, matching the sorting behavior of other tabs. Tests verify the implementation against the code.

Changes

Memory List Sorting

Layer / File(s)	Summary
Memory sorting implementation src/viewer/index.html	loadMemories() copies API memories into a local array, sorts by descending createdAt with updatedAt fallback, assigns the sorted list to state, and sets the total from the API response or item count.
Memory sorting tests test/viewer-memories-sort.test.ts	Vitest suite confirms loadMemories() sorts newest-first by createdAt descending, falls back to updatedAt when missing, and follows the same localeCompare pattern as Sessions/Metrics sorting.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 Memories now bloom in order bright,
Newest first, a sorting delight—
No more scrolling through ancient lore,
Just fresh thoughts at the top floor!
Tests confirm the pattern's right.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix(viewer): sort Memories tab newest first (#674)' directly and clearly describes the main change: sorting the Memories tab to display newest entries first.
Linked Issues check	✅ Passed	The PR fully implements the coding requirement from issue #674: sorting Memories tab entries newest-first by createdAt with updatedAt fallback, matching Sessions/Metrics behavior.
Out of Scope Changes check	✅ Passed	All changes are directly scoped to addressing issue #674: sorting logic in loadMemories() and corresponding test coverage with no extraneous modifications.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch fix/674-viewer-memories-sort

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint skipped: no ESLint configuration detected in root package.json. To enable, add eslint to devDependencies.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (1)

test/viewer-memories-sort.test.ts (1)

27-30: ⚡ Quick win

Loosen the Sessions/Metrics parity regex to avoid brittle failures.

The exact one-line sessions.sort(...) pattern is formatting-sensitive and can fail on harmless refactors. Match the semantic shape (descending localeCompare) with a less rigid regex.

Proposed adjustment

-      /sessions\.sort\(function\(a, b\) \{ return \(b\.startedAt \|\| ''\)\.localeCompare\(a\.startedAt \|\| ''\); \}\)/,
+      /sessions\.sort\([\s\S]*?\(b\.startedAt\s*\|\|\s*['"]{2}\)\.localeCompare\(\s*a\.startedAt\s*\|\|\s*['"]{2}\s*\)/,

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@test/viewer-memories-sort.test.ts` around lines 27 - 30, The test's strict
regex for the "Memories sort mirrors the Sessions/Metrics localeCompare
descending pattern" assertion is brittle; update the matcher for the viewer
variable to allow formatting differences while still ensuring a descending
localeCompare on startedAt — i.e., relax the pattern to look for
sessions.sort(...) that contains localeCompare and the operands in descending
order (b.startedAt vs a.startedAt), permit arbitrary whitespace/newlines and
optional || '' or other minor variations, and avoid matching the entire one-line
function text verbatim so harmless reformatting won't break the test.

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@test/viewer-memories-sort.test.ts`:
- Around line 27-30: The test's strict regex for the "Memories sort mirrors the
Sessions/Metrics localeCompare descending pattern" assertion is brittle; update
the matcher for the viewer variable to allow formatting differences while still
ensuring a descending localeCompare on startedAt — i.e., relax the pattern to
look for sessions.sort(...) that contains localeCompare and the operands in
descending order (b.startedAt vs a.startedAt), permit arbitrary
whitespace/newlines and optional || '' or other minor variations, and avoid
matching the entire one-line function text verbatim so harmless reformatting
won't break the test.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: cb4886f9-5156-4233-a22f-aee98e4d3ace

📥 Commits

Reviewing files that changed from the base of the PR and between 7f3a757 and 8a8e8ce.

📒 Files selected for processing (2)

• src/viewer/index.html
• test/viewer-memories-sort.test.ts