fix: stop mapping Public Domain ROMs to Poland#3671
Merged
Conversation
chiyi-creator
force-pushed
the
fix/public-domain-rom-tag
branch
from
July 4, 2026 16:17
ac12419 to
8fed0be
Compare
gantoine
approved these changes
Jul 4, 2026
chiyi-creator
force-pushed
the
fix/public-domain-rom-tag
branch
from
July 4, 2026 16:35
8fed0be to
e1a9c0b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the display of ROMs tagged as
PD/Public Domain.The backend already parses the
PDfilename tag correctly asPublic Domain, butregionToEmoji()incorrectly mapped bothPDandPublic Domainto the Poland flag. On platforms that render regional indicator emojis as flags, this caused Public Domain ROMs to appear as Polish.Changes
PDandPublic DomainPDandPublic DomainTesting
npm test -- test/utils.test.tsnpm test— 454 tests passednpm run typechecknpm run buildFixes #3630
AI assistance disclosure
I used ChatGPT to assist with codebase navigation, debugging, test planning, and drafting parts of the regression test. I manually reviewed the changes and ran the complete test, type-check, and build commands locally.