Skip to content

fix: display selected firmware in player#3673

Merged
gantoine merged 1 commit into
rommapp:masterfrom
chiyi-creator:fix/firmware-select-display
Jul 4, 2026
Merged

fix: display selected firmware in player#3673
gantoine merged 1 commit into
rommapp:masterfrom
chiyi-creator:fix/firmware-select-display

Conversation

@chiyi-creator

Copy link
Copy Markdown
Contributor

Summary

Fixes the firmware selector in the v2 EmulatorJS player so that the
selected firmware remains visible after selection.

The selector model stores a FirmwareSchema object, but the options were
wrapped as { title, value: firmware }. This allowed the selected firmware
to be passed to the player, but prevented RSelect from resolving and
displaying the selected item correctly.

Changes

  • Pass firmware objects directly to RSelect
  • Use file_name as the visible item title
  • Use id as the stable item value
  • Enable return-object so the player continues receiving a
    FirmwareSchema object

Testing

  • npx prettier --check src/v2/views/Player/EmulatorJS.vue
  • npm run typecheck
  • npm test
  • npm run build

Fixes #3662

AI assistance disclosure

I used ChatGPT to assist with codebase navigation, diagnosis of the
RSelect model-value mismatch, and review of the proposed fix. I manually
reviewed the final change and ran all listed checks locally.

@gantoine gantoine merged commit aabe65c into rommapp:master Jul 4, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Visual - Selecting firmware to play in browser doesn't show selection.

2 participants