fix: display selected firmware in player#3673
Merged
gantoine merged 1 commit intoJul 4, 2026
Merged
Conversation
gantoine
approved these changes
Jul 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the firmware selector in the v2 EmulatorJS player so that the
selected firmware remains visible after selection.
The selector model stores a
FirmwareSchemaobject, but the options werewrapped as
{ title, value: firmware }. This allowed the selected firmwareto be passed to the player, but prevented
RSelectfrom resolving anddisplaying the selected item correctly.
Changes
RSelectfile_nameas the visible item titleidas the stable item valuereturn-objectso the player continues receiving aFirmwareSchemaobjectTesting
npx prettier --check src/v2/views/Player/EmulatorJS.vuenpm run typechecknpm testnpm run buildFixes #3662
AI assistance disclosure
I used ChatGPT to assist with codebase navigation, diagnosis of the
RSelectmodel-value mismatch, and review of the proposed fix. I manuallyreviewed the final change and ran all listed checks locally.