-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[cppyy] Enable tests on windows #18872
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aaronj0
wants to merge
7
commits into
root-project:master
Choose a base branch
from
aaronj0:cppyy-win-tests
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+152
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results 22 files 22 suites 3d 21h 45m 31s ⏱️ For more details on these failures, see this check. Results for commit 7897153. ♻️ This comment has been updated with latest results. |
Contributor
2025-05-26T19:53:28.0200811Z 24: if sc == -1:
2025-05-26T19:53:28.0200984Z 24: > raise RuntimeError("Unable to load reflection library "+name)
2025-05-26T19:53:28.0201385Z 24: E RuntimeError: Unable to load reflection library C:\ROOT-CI\build\bindings\pyroot\cppyy\cppyy\test/stltypesDictLooks like we have to use a proper |
6477723 to
7897153
Compare
7897153 to
bff3898
Compare
78cadc7 to
798a12b
Compare
Thanks to Bertrand
Commit 5c60f6e changed the concatenations of paths to something not platform independent, by doing string concatenation with `"/"` explicitly. This has to be reverted, using `Path.join` again.
75f2a77 to
bfa48fe
Compare
bfa48fe to
a0fd644
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trigger a verbose CI run with Windows to examine the cppyy test status