Fix typo in TAttText::GetTextSizePercent#22197
Merged
linev merged 1 commit intoroot-project:masterfrom May 11, 2026
Merged
Conversation
Returns wrong size for the font with pixel size. Fixes root-project#22195
1 task
pcanal
reviewed
May 8, 2026
Member
pcanal
left a comment
pcanal
left a comment
There was a problem hiding this comment.
LGTM (although calling it a 'typo' undervalue the effect).
pcanal
approved these changes
May 8, 2026
Test Results 22 files 22 suites 3d 13h 9m 53s ⏱️ For more details on these failures, see this check. Results for commit 110e3c7. |
Member
|
to be backported to 6.40 @linev |
dpiparo
approved these changes
May 9, 2026
Member
Author
No, it is very recent bug, not present in 6.40 branch. We missing test for this font precision - this I will add soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Returns wrong size for the font with pixel size.
Fixes #22195