[core] Handle non-space whitespace in TClassEdit::CleanType#22766
Open
guitargeek wants to merge 1 commit into
Open
[core] Handle non-space whitespace in TClassEdit::CleanType#22766guitargeek wants to merge 1 commit into
guitargeek wants to merge 1 commit into
Conversation
Test Results 23 files 23 suites 3d 16h 29m 59s ⏱️ For more details on these failures, see this check. Results for commit 86afdaf. ♻️ This comment has been updated with latest results. |
ferdymercury
reviewed
Jul 7, 2026
| if (c[0]==' ') { | ||
| if (std::isspace(c[0])) { | ||
| if (kbl) continue; | ||
| if (!isalnum(c[ 1]) && c[ 1] !='_') continue; |
Collaborator
There was a problem hiding this comment.
Suggested change
| if (!isalnum(c[ 1]) && c[ 1] !='_') continue; | |
| if (c + 1 == nullptr || (!isalnum(c[ 1]) && c[ 1] !='_')) continue; |
should this be maybe guarded?
Contributor
Author
There was a problem hiding this comment.
I'm assuming here that c is not nullptr, because typesDesc is expected to be a non-nullptr input. Then, also the c + 1 expression can also never be nullptr. About accessing the elements: reading c[1] is safe because the loop condition *c guarantees c[0] != '\0', so c[1] is at most the null terminator.
A class name in a selection XML can span multiple lines. `CleanType()` only treated `' '` as a blank, so a newline was kept in the cleaned name and, when the template arguments were later re-processed individually, an argument starting with a newline was truncated to an empty string. This corrupted the rootmap entries and the alternate name registrations (e.g. `"Foo<,vector<float>,>"`), leading to `"Second registration of ..."` errors from `TClassTable::AddAlternate` at library load time. Treat all whitespace like a space: drop it where a space would be dropped, and emit a single plain space where it separates two identifiers. Closes root-project#22359. 🤖 Done with the help of AI.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A class name in a selection XML can span multiple lines.
CleanType()only treated' 'as a blank, so a newline was kept in the cleaned name and, when the template arguments were later re-processed individually, an argument starting with a newline was truncated to an empty string. This corrupted the rootmap entries and the alternate name registrations (e.g."Foo<,vector<float>,>"), leading to"Second registration of ..."errors fromTClassTable::AddAlternateat library load time.Treat all whitespace like a space: drop it where a space would be dropped, and emit a single plain space where it separates two identifiers.
Closes #22359.
🤖 Done with the help of AI.