add comment on updating Airtable rev-prod for new editors#1005
Open
add comment on updating Airtable rev-prod for new editors#1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@maelle The change to https://github.com/ropensci/dev_guide/blob/main/scripts/airtable-get-data.R is key - some
editorvalues areNA, and these are retained and listed as editors at https://devguide.ropensci.org/softwarereview_intro.html#editorial-team. The Airtable fields are empty, just like the standard NULL ones, so I don't know where theNAs come from, but this fixes. I've also updated all Airtable records, and added extra lines to instructions on what I did there. This should fix the list.(Oh, and we currently have only one ed on leave, Anna Krystalli, and she's cool with being unlisted there; there'll likely be another soon joining the indefinite-leave crew, but treating them as Emeritus in this context is fine.)
Checklist for dev guide maintainers, do not delete 😸