Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies#238
Merged
sloretz merged 3 commits intoros2:rollingfrom Jan 16, 2026
Merged
Add DEPENDS_EXPLICIT_ONLY to remove implicit dependencies#238sloretz merged 3 commits intoros2:rollingfrom
sloretz merged 3 commits intoros2:rollingfrom
Conversation
Signed-off-by: Anthony Welte <tony.welte@gmail.com>
TonyWelte
force-pushed
the
bugfix/remove-implicit-dependencies
branch
3 times, most recently
from
0e80c0d to
e093302
Compare
Signed-off-by: Anthony Welte <tony.welte@gmail.com>
TonyWelte
force-pushed
the
bugfix/remove-implicit-dependencies
branch
from
e093302 to
69e6e97
Compare
This was referenced Oct 8, 2025
Contributor
|
@Mergifyio update |
Contributor
✅ Branch has been successfully updated |
sloretz
approved these changes
Jan 16, 2026
Contributor
|
Pulls: ros2/rosidl#910, ros2/rosidl_typesupport#168, ros2/rosidl_typesupport_fastrtps#136, #238
|
Contributor
|
Thank you for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In Draft until ros2/rosidl#910 is reviewed.When add_custom_command is used to generate files that are then used by a target, the add_custom_command becomes implicitly dependent on the target dependencies. In rosidl add_custom_command is used to generate files from the IDL files, the generator does not depend on anything else.
This PR (and the equivalent for ros2/rosidl#910, ros2/rosidl_typesupport_fastrtps#136 and ros2/rosidl_typesupport#168) adds the DEPENDS_EXPLICIT_ONLY option of add_custom_command to most generators.
See ros2/rosidl#910 for more details
Is this user-facing behavior change?
Did you use Generative AI?
Additional Information