nix: Fix identifier lexing #2181
Open
+14
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsfisis
force-pushed
the
nix/fix-ident-lexing
branch
from
f82436b to
9ba25b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2176
Nix identifiers can contain
'and-, which are not "word" characters in Ruby regexp. Thus, the pattern/if\b/(literal "if" followed by a word boundary) will match withifwithinif'.This pull request defines
id_boundarypattern as/(?![a-zA-Z_0-9'-])/, "not followed by Nix identifier characters" and replaces\bwith it.Nix manual:
https://nix.dev/manual/nix/2.28/language/identifiers.html