Conversation
The banner now scales to fill the terminal, using the largest cell size the width allows and growing the height to match (chunky letters), instead of strict proportional scaling that left a long label like IN REVIEWS at 1x (7 rows) and tiny on a fullscreen window. Also honor COLUMNS/LINES env vars as a size fallback for non-TTY output, so a piped run can render at an explicit size for preview. core: renderBanner scale rule. cli: divider size fallback. docs: history. version 3.6.0 to 3.6.1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mx divider now scales to fill the terminal, using the largest cell size the width allows and growing the height to match (chunky letters), instead of strict proportional scaling that left a long label like IN REVIEWS at 1x (7 rows) and tiny on a fullscreen window. It also honors COLUMNS/LINES env vars as a size fallback for non-TTY output, so a piped run can render at an explicit size for preview.
Renderer-only change in @mx/core (renderBanner) plus the CLI size fallback. typecheck, lint, tests (112), and build all pass.