Skip to content

feat(rsdoctor): add tree shaking skills#34

Merged
yifancong merged 2 commits intomainfrom
feat/rsdoctor-skill-tree-shaking
Mar 20, 2026
Merged

feat(rsdoctor): add tree shaking skills#34
yifancong merged 2 commits intomainfrom
feat/rsdoctor-skill-tree-shaking

Conversation

@yifancong
Copy link
Copy Markdown
Contributor

@yifancong yifancong commented Mar 19, 2026

This pull request introduces a new set of tree-shaking analysis commands to the rsdoctor-analysis CLI and refactors the API usage in the rsdoctor.js script for improved clarity and maintainability. The most impactful change is the addition of comprehensive tree-shaking diagnostics, enabling users to detect and analyze issues that prevent dead-code elimination in their bundles. Additionally, the refactoring of API constants and request functions streamlines the code and reduces repetition.

Tree-shaking analysis feature additions:

  • Added a new tree-shaking command group to the CLI, including subcommands for detecting side-effects-only imports (E1007), CJS require usage (E1008), ESM-to-CJS resolution issues (E1009), a summary report, module bailout reasons, and exports analysis. (packages/rsdoctor-analysis/src/commands/tree-shaking.ts)
  • Registered the new tree-shaking commands in the CLI entrypoint, making them available to users. (packages/rsdoctor-analysis/src/command.ts)

E1007-E1009 docs:
web-infra-dev/rsdoctor#1571
web-infra-dev/rsdoctor#1586

Demo

@yifancong yifancong marked this pull request as draft March 19, 2026 03:23
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the rsdoctor analysis tool by integrating advanced tree-shaking capabilities. It provides developers with a powerful suite of commands to diagnose and understand why certain modules are not being tree-shaken, offering insights into common pitfalls like side effects, CJS dependencies, and ESM-to-CJS resolution issues. This addition aims to help optimize bundle sizes and improve application performance by making tree-shaking inefficiencies more transparent and actionable.

Highlights

  • New Tree-Shaking Analysis Commands: Introduced a new set of CLI commands under rsdoctor tree-shaking to provide detailed analysis and diagnostics for tree-shaking issues.
  • Comprehensive Tree-Shaking Diagnostics: Added commands to detect specific tree-shaking violations, including side-effects-only imports (E1007), CJS require() calls (E1008), and ESM imports resolving to CJS (E1009).
  • Module Bailout Reasons and Export Analysis: Implemented functionalities to summarize tree-shaking health, list modules that cannot be tree-shaken with their bailout reasons, and analyze module exports to identify optimization opportunities.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new set of tree-shaking analysis commands to the rsdoctor-analysis tool. A new file, tree-shaking.ts, was added to define commands for detecting side-effects-only imports (E1007), CJS require() calls (E1008), and ESM imports resolving to CJS (E1009), along with commands for a comprehensive tree-shaking summary, bailout reasons, and exports analysis. These new commands are integrated into the main CLI program by importing and registering them. Additionally, the bundled rsdoctor.js file was updated to reflect these new functionalities, including renaming internal API constants and request functions for consistency.

@yifancong yifancong marked this pull request as ready for review March 20, 2026 08:04
@yifancong yifancong requested a review from chenjiahan March 20, 2026 08:05
@yifancong yifancong enabled auto-merge (squash) March 20, 2026 09:51
@yifancong yifancong merged commit 6923695 into main Mar 20, 2026
4 checks passed
@yifancong yifancong deleted the feat/rsdoctor-skill-tree-shaking branch March 20, 2026 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants