refactor: bundle connect-history-api-fallback#181
Merged
chenjiahan merged 1 commit intomainfrom Apr 1, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR makes connect-history-api-fallback load via a typed dynamic import so it can be included in the server build output rather than relied on as a runtime external.
Changes:
- Replace
require('connect-history-api-fallback')withawait import('connect-history-api-fallback')(typed via@types/connect-history-api-fallback). - Stop externalizing
connect-history-api-fallbackin the server build config to allow bundling it. - Move
connect-history-api-fallbacktodevDependenciesand add its type package.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/server.ts | Switches history API fallback middleware loading from require to dynamic import() and aligns middleware typing. |
| rslib.config.ts | Removes connect-history-api-fallback from externals so it can be bundled into the server output. |
| package.json | Moves connect-history-api-fallback to devDependencies and adds @types/connect-history-api-fallback. |
| pnpm-lock.yaml | Lockfile updates for the dependency move and added type packages. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR switches
connect-history-api-fallbackto a typed dynamic import so the server bundle can load it without relying on a runtime external. It also moves the package intodevDependenciesand adds the matching type package to keep the build self-contained.Testing
pnpm buildpnpm lintRelated Links
None