feat: add examples & modern integration tests to rstest eco ci

[9aoy]

add examples & modern integration tests to rstest-ecosystem-ci.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the rstest ecosystem CI by incorporating dedicated test configurations for examples and integrating rstest specific tests into the existing Modern.js test suite. The changes aim to improve the robustness and coverage of the CI, ensuring better validation of rstest's functionality across different use cases and frameworks.

Highlights

• New Test Configuration for Examples: A new test configuration file, tests/rstest/examples.ts, has been added to integrate rstest examples from the rstackjs/rstack-examples repository into the ecosystem CI.
• Expanded Modern.js Integration Tests: The existing tests/rstest/modernjs.ts test suite has been updated to include rstest specific integration tests, enhancing the coverage for the Modern.js framework within the ecosystem CI.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• tests/rstest/examples.ts
  • Added a new test configuration for rstest examples.
• tests/rstest/modernjs.ts
  • Updated the modernjs test suite to include rstest integration tests.

Ignored Files

• Ignored by pattern: .github/workflows/** (3)
  • .github/workflows/rstest-ecosystem-ci-from-commit.yml
  • .github/workflows/rstest-ecosystem-ci-from-pr.yml
  • .github/workflows/rstest-ecosystem-ci-selected.yml

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request expands the integration tests for rstest-ecosystem-ci by adding tests for the rstack-examples and modern.js repositories. The changes are clear and directly contribute to improving test coverage. I have one suggestion to improve the maintainability of the new test command for modern.js.

[gemini-code-assist]

Using cd within the test command string can be fragile. If the directory structure changes, this command might fail or, worse, fail silently without running the intended tests. It would be more robust to specify the working directory separately if the runInRepo utility allows it. This would improve the maintainability and reliability of the test setup. If the utility doesn't currently support this, it might be a worthwhile enhancement for the future.