rename pm_newline_list_t to pm_line_offset_list_t#3925
Open
rename pm_newline_list_t to pm_line_offset_list_t#3925
pm_newline_list_t to pm_line_offset_list_t#3925Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #3860 (comment) , this PR changes
pm_newline_list_tto (the admittedly awkward)pm_line_offset_list_t, along with the associated functions for the list. I also attempted to update the docs and field names to reflect the new name and/or eliminate ambiguity around the term "newlines".I tried to separate things out into fairly bite-sized pieces for review, and for my own ability to do bits and pieces of the work along the way. I am happy to squash these down to a single commit before merging.