Conversation
kddnewton
force-pushed
the
todos
branch
3 times, most recently
from
e389ee6 to
6508059
Compare
Member
|
Nice! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Generate RBS through inline annotations instead of through maintaining separate RBS files.
I have wanted this for a while, but frankly it has been daunting to try to convert the whole codebase, and previously Steep would just hang. It looks like it has gotten better to the point where this is now possible. The
typecheck:steepcodebase will now first extract out inline type annotations and put them into the sig directory. You can effectively ignore all files in that directory for the purposes of review.At present, this means basically the entire codebase is typechecked with steep, except the translation directory which depends on type signatures for parser/ripper/ruby_parser which do not exist.