update rbs signatures to be more consistent with generics#2867
Open
sampersand wants to merge 1 commit intoruby:masterfrom
Open
update rbs signatures to be more consistent with generics#2867sampersand wants to merge 1 commit intoruby:masterfrom
sampersand wants to merge 1 commit intoruby:masterfrom
Conversation
sampersand
force-pushed
the
swesterman/2026-03-05/rename-from-Elem-to-T
branch
from
fc974c2 to
f07be48
Compare
sampersand
force-pushed
the
swesterman/2026-03-05/rename-from-Elem-to-T
branch
from
f07be48 to
648b3c9
Compare
Contributor
|
I prefer |
sampersand
force-pushed
the
swesterman/2026-03-05/rename-from-Elem-to-T
branch
from
648b3c9 to
04dbd0b
Compare
sampersand
force-pushed
the
swesterman/2026-03-05/rename-from-Elem-to-T
branch
from
04dbd0b to
7b97246
Compare
Contributor
Author
Done. It also prevents a lot of annoying conflicts where |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR: This migrates RBS signatures to use single-characters instead of multiple charcaters.
RBS is a bit inconsistent about how generic variables (eg
Foo[X, Y]) are named: Some of them are long (Array[Elem],Enumerable[Elem],ObjectSpace::WeakMap[Key, Value]), whereas some of them are short (Hash[K, V],Set[A], and most exceptions likeFrozenError[T],KeyError[K, R].)I talked with @soutaro about this, and he liked the idea of the one-charcater variables (which I'm also partial to—it's how most langauges work, and makes it easier to distinguish them from classnames). This PR implements that