Skip to content

HOLD: Confirm registrants with a "You're registered!" banner#1764

Open
maebeale wants to merge 1 commit into
mainfrom
maebeale/registration-success-banner
Open

HOLD: Confirm registrants with a "You're registered!" banner#1764
maebeale wants to merge 1 commit into
mainfrom
maebeale/registration-success-banner

Conversation

@maebeale

Copy link
Copy Markdown
Collaborator

Closes [link an issue or remove this line]

What is the goal of this PR and why is this important?

  • After a successful public event registration, the registrant landed on the ticket page with no explicit "you're in" confirmation beyond the transient flash toast.

How did you approach the change?

  • The success redirect carries a registered flag to the ticket page.
  • registrations#show sets @just_registered for that flag or a successful Stripe checkout=success return, and the ticket view renders a green "You're registered!" banner above the ticket.
  • The banner is not shown on plain return visits to an existing ticket URL. The existing "You have been successfully registered!" flash toast is unchanged.

UI Testing Checklist

  • Register on a free event → land on the ticket page with a "You're registered!" banner.
  • Pay by card and complete Stripe checkout → ticket page shows the banner.
  • Re-open an existing ticket URL directly → no banner.

Anything else to add?

After a successful public registration the registrant landed on the ticket
page with only a transient flash toast — no durable confirmation they were in.

Carry a `registered` flag to the ticket page on the success redirect; show a
green "You're registered!" banner above the ticket when arriving from a fresh
registration or a successful Stripe `checkout=success` return, but not on plain
return visits.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
flash.now[:alert] = "Payment was cancelled. You are registered for this event but payment may still be due."
end

@just_registered = params[:registered].present? || params[:checkout] == "success"

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 From Claude: Banner fires for a fresh registration (?registered=true) and a successful Stripe return (checkout=success), but not on plain ticket re-visits.

@maebeale maebeale marked this pull request as ready for review June 19, 2026 03:58
@maebeale maebeale changed the title Confirm registrants with a "You're registered!" banner HOLD: Confirm registrants with a "You're registered!" banner Jun 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant