Archipelago Plugin UI Rework#12217
Open
digiholic wants to merge 3 commits into
Open
Conversation
Ports the UI rework from the Beta Members Randomizer into the base free-to-play randomizer version
Contributor
|
You need to add the build type to your runelite-plugin.properties. I think since you are depending on the websocket library you'll need |
ldavid432
added
the
waiting for author
runelite-github-app
Bot
removed
the
waiting for author
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
Member
|
are you able/willing to drop your websocket dependency and switch over to okhttp websockets, that would allow you to set build=standard and then your plugin could be automatically reviewed by the bot. this should be possible for you since okhttp3 websockets do the permessage-deflate stuff automatically afaik |
riktenx
added
the
waiting for author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the UI rework from the Beta Members Randomizer into the base free-to-play randomizer version