Skip to content

Lending Tracker: fix cross-machine invite codes & sync reliability#12343

Open
Guess34 wants to merge 4 commits into
runelite:masterfrom
Guess34:master
Open

Lending Tracker: fix cross-machine invite codes & sync reliability#12343
Guess34 wants to merge 4 commits into
runelite:masterfrom
Guess34:master

Conversation

@Guess34

@Guess34 Guess34 commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

Patch update

  • Fixed invite codes failing to join across computers.
  • Cloud Sync now activates immediately when toggled on (no restart).
  • Invite codes are confirmed published before sharing; clearer join error messages.
  • Added a relay keepalive and catch-up sync so joiners get current group state.
  • "Invite to Lending Group" now anchors on the player "Report" option.

Cloud Sync remains opt-in and off by default. No new dependencies.

@runelite-github-app

runelite-github-app Bot commented Jun 1, 2026

Copy link
Copy Markdown

@runelite-github-app

runelite-github-app Bot commented Jun 1, 2026

Copy link
Copy Markdown

This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed.


Internal use only: Reviewer details Maintainer details

@riktenx

riktenx commented Jun 6, 2026

Copy link
Copy Markdown
Member
  • thread sleep is not allowed
  • thread interrupt is not allowed

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 6, 2026
Removed sleep and interrupt
@runelite-github-app runelite-github-app Bot removed the waiting for author waiting for the pr author to make changes or respond to questions label Jun 7, 2026
@riktenx riktenx removed the size-m label Jun 22, 2026
@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 22, 2026
@runelite-github-app runelite-github-app Bot added size-m and removed waiting for author waiting for the pr author to make changes or respond to questions labels Jun 26, 2026
@riktenx

riktenx commented Jun 27, 2026

Copy link
Copy Markdown
Member

you need much stricter gating of requests to your backend behind the opt-in flag. every api call should have a check for the optin config right before it, that throws an exception / returns early if it happens to be false, so it is exhaustively clear from reading the code that you're not making requests without user consent.

@riktenx riktenx added the waiting for author waiting for the pr author to make changes or respond to questions label Jun 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

plugin change size-m waiting for author waiting for the pr author to make changes or respond to questions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants