Release Xtreme Tasker v2: UI improvements + bug fixes #12785
Conversation
|
This plugin requires a review from a Plugin Hub maintainer. The reviewer will request any additional changes if needed. Internal use only: Reviewer details Maintainer details |
|
Your plugin has too much code to be reviewed. We have a maximum of 200k tokens and your plugin has ~260k. Only source code in your main source set is counted and comments are excluded. Unit tests are excluded and any resource files are also excluded. We do not have the capacity to review a plugin of this size, much less a 20k LoC diff, so if you want to be able to update this plugin you will need to substantially shrink the size of your codebase. Some things that might help
I am sure you can ask your LLM to help you reduce the size of your codebase (and point it at this comment) and it will be able to do so without compromising the functionality of your plugin. |
|
Sorry about that, wasn't aware of the limits, thanks for letting me know! Will chunk PRs in even smaller units in the future. Made following updates: |
|
Sigh, with trying to reduce codebase size, increased LoC. Will re-sumbit smaller chunks. @riktenx can you please point me to documentation regarding LoC size limits (looks like tests, docs, jsons etc are included in this, despite being omitted for token count), as well as how tokens are calculated? LLM only calculated 207K when you said 260K, so I do not have a way to officially check this on my end. Thanks! |
|
there is no documentation, i would just write a script or something that creates a copy of your we don't really care about LoC fwiw |
|
to clarify there is no explicit LoC limit. if your code can be bot-reviewed we basically don't care how much actual LoC you have, because the bot operates on LLM tokens. if your code cannot be bot reviewed then a reviewer's (all of whom are volunteers, and few of which are active at any given time) capability / desire to look at your code is inversely proportional to how big it is, at twenty thousand lines of code that is naturally nonexistent. in the era of generative ai tools we basically don't have the capacity to hand-review code at the scale at which it is being submitted anymore for all intents and purposes if you want to be updating your plugin you should keep it well under that 200k token limit so the bot can approve it |
|
@riktenx Awesome, I appreciate the insight! Working on getting my codebase below 200K tokens. Reopening PR and will push in update to reduce ASAP! Thanks again! |
|
repo size appears to be good now. all of your file i/o needs to be within a plugin-specific subdir in .runelite, right now you're doing a file walk directly in .runelite which is not allowed |
|
@riktenx awesome, thanks again for guidance on getting codebase to a decent size! And scan has been removed, I'm only looking through .runelite/xtreme-tasker-states now. |
516fa5d
into
runelite:master
Uh oh!
There was an error while loading. Please reload this page.