Omit the branch name when matching packages in manifest.json#131
Merged
Omit the branch name when matching packages in manifest.json#131
Conversation
palinatolmach
approved these changes
Dec 2, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #130
The
kontrolpackage is defined inavailable_packageswith a specific branch:From the
manifest.json, we can see that the kontrol entry looks like this:{ "kontrol": { "active": true, "attrPath": "packages.x86_64-linux.kontrol", "originalUrl": "github:runtimeverification/kontrol/acca16ffd6f4e693b7bda2dd8ca99eb335057dbe?narHash=...", "url": "github:runtimeverification/kontrol/acca16ffd6f4e693b7bda2dd8ca99eb335057dbe?narHash=..." }, }When kup tries to match the installed packages with the available packages, it compares the
repo_path(which includes the branch) with the url from the manifest (which does not include the branch). This mismatch causes kup to incorrectly conclude that kontrol is not installed.