-
Notifications
You must be signed in to change notification settings - Fork 51
Bitreq client builder (rustls + native-tls) #516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
APonce911
wants to merge
70
commits into
rust-bitcoin:master
Choose a base branch
from
APonce911:bitreq-client-builder-native-tls
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+596
−42
Open
Changes from all commits
Commits
Show all changes
70 commits
Select commit
Hold shift + click to select a range
13e0cfd
update test_https to use local http server
APonce911 e879020
add test_https_with_client
APonce911 182e5fb
WIP: add ClientBuilder for configuring Client instances
APonce911 92ca975
WIP: pass ClientConfig struct to tls layer
APonce911 5af7539
WIP: include feature on ClientConfig import
APonce911 b6650ba
WIP append custom cert
APonce911 bf1735d
WIP: update tests
APonce911 da22cf9
rename TlsConfig cert attribute
APonce911 a01979a
remove comment
APonce911 d89f559
style adjustment
APonce911 04a1c3a
add example
APonce911 7011045
Code review adjustment: Use AsyncConnection::new instead of new_with_…
APonce911 deb5397
WIP: include certificates on TlsConfig struct
APonce911 5a97e80
style adjustment
APonce911 a61b1ec
make rustls_stream mod public temporarily
APonce911 8000c6c
WIP: create Certificates wrapper on rustls_stream mod
APonce911 9b4a839
WIP use custom error when appending a certificate
APonce911 8d7ff6c
WIP remove moved code
APonce911 0538906
WIP remove unused field from TlsConfig
APonce911 5fc031b
add Certificates module
APonce911 9c11211
adjust privacy on structs
APonce911 22c2b2f
add new docs
APonce911 97b5d56
update doc and example
APonce911 4a08c7d
remove comment
APonce911 2cf40aa
Adjust custom_cert example feature
APonce911 937e3ba
fix: correct feature flag for CustomClientConfig import
APonce911 e682f92
List adjustments
APonce911 fd47ea1
fix Cargo fmt adjustments
APonce911 728ceb4
Rename `certificate` to `cert_der`
APonce911 c9d941d
take ownership of cert_der on append_certificate
APonce911 0f67697
rename parameter cert_der on Doc for with_root_certificate
APonce911 65e7c41
Reuse existing TLSConfig if possible - allows for multiple certificat…
APonce911 ecf4d12
Update TlsConfig::new and ClientBuilder::with_root_certificate to ret…
APonce911 c11c920
Update custom_cert example with new return from with_root_certificate…
APonce911 89153aa
Native-tls https adjustments
APonce911 86e01c1
add new tests
APonce911 b5c2108
WIP: native-tls client builder setup
APonce911 cc84c5c
Fix test flags
APonce911 abf89cf
warnings fix
APonce911 cccf43a
Merge with branch bitreq-client-builder
APonce911 8936da6
style adjustment
APonce911 315a3c8
warnings fix
APonce911 e8f47b6
fix: unresolved import - Refactor client mod to allow cleaner conditi…
APonce911 97124a9
Gate tls modules declarations
APonce911 8382cc1
Fix doctest
APonce911 2726d13
Merge branch 'bitreq-client-builder' into bitreq-client-builder-nativ…
APonce911 5bb6df5
Merge branch bitreq-client-builder
APonce911 d3470a9
Improve error handling
APonce911 05f8e5d
remove connector caching with client_config - always create new conne…
APonce911 2ef687e
Improve code organization: Move Client and ClientImpl declarations be…
APonce911 bfe2763
wrap ClientConfig with Arc smart pointer to reduce memory usage
APonce911 b2fe156
Merge branch 'master' into bitreq-client-builder
APonce911 8c5c9f4
Merge branch ´bitreq-client-builder´
APonce911 1a6fcc3
remove connector caching with client_config - create new connector
APonce911 f3851fb
use Arc clone instead of option clone
APonce911 53391ef
Merge branch 'bitreq-client-builder' into bitreq-client-builder-nativ…
APonce911 6ac03d7
Wrap Certificates with arc and inject from Client - load root_certs o…
APonce911 66769f4
Merge branch 'bitreq-client-builder' into bitreq-client-builder-nativ…
APonce911 0ccf01a
Adjust gates on Client
APonce911 c6d6ccd
format adjustment
APonce911 bf3a952
bump default Client default connection pool(capacity) to 10
APonce911 5d0d0c1
Merge branch 'bitreq-client-builder' into bitreq-client-builder-nativ…
APonce911 694adbf
native-tls support for multiple certs - make client builder method fa…
APonce911 005e00a
update example
APonce911 908a8cf
fix example feature gates
APonce911 67328f7
code review adjustment: remove example
APonce911 6194faa
code review adjustment: remove tls:enabled and tls:disabled modules
APonce911 27eac43
code review adjustment: reduce docs
APonce911 503702b
Implement disable_default_certificates function for client builder
APonce911 ee83cc2
code review adjustment: streamline code and reduce complexity to avoi…
APonce911 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.