Use consistent capitalization for (Script)PubKey#524
Merged
tcharding merged 1 commit intorust-bitcoin:masterfrom Feb 27, 2026
Merged
Conversation
The capitalization of key in pubkey and scriptpubkey is inconsistent. Core uses a capital K in e.g. scriptPubKey in gettxout. Search the whole codebase for "Pubkey" and change them all to "PubKey". No changes made where the p is lowercase.
tcharding
approved these changes
Feb 26, 2026
tcharding
reviewed
Feb 26, 2026
| Pubkey, | ||
| /// Pubkey hash output script. | ||
| PubkeyHash, | ||
| /// PubKey output script. |
Member
There was a problem hiding this comment.
I'm surprised the linter doesnt' complain about this? If it starts doing so I'm inclined to think we should just use 'pubkey' and 'Pubkey' (capitalized) in docs and not add an attribute to shoosh the linter.
Member
|
Weird, the merge script just started erroring even though I only just merged #519 with it. Going to click the button and leave in case GitHub is just gliching out right now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capitalization of key in pubkey and scriptpubkey is inconsistent. Core uses a capital K in e.g. scriptPubKey in gettxout, and a capital K is more common in rust-bitcoin.
Search the whole codebase for "Pubkey" and change them all to "PubKey". No changes made where the p is lowercase.
Closes #371