Remove asm_const attribute because it is no longer required#220
Draft
ChocolateLoverRaj wants to merge 2 commits intorust-embedded:masterfrom
Draft
Remove asm_const attribute because it is no longer required#220ChocolateLoverRaj wants to merge 2 commits intorust-embedded:masterfrom
asm_const attribute because it is no longer required#220ChocolateLoverRaj wants to merge 2 commits intorust-embedded:masterfrom
Conversation
Member
|
If we rely on recent features, we probably need to update https://github.com/rust-embedded/rust-raspberrypi-OS-tutorials/blob/master/rust-toolchain.toml as well. |
Author
|
I updated the toolchain. As I go through the tutorials there are more things that need to be changed to work with the latest Rust version. Should I make a PR that updates all tutorials to work? Is there a shortcut for having to modify changes from |
Member
|
I would suggest that you fork this tutorial and work on a branch, fixing things as you go with one commit per fix. Then submit a PR to bring your branch to mainline and we can discuss it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I got this error:
so I removed the line and created this PR. I tested it in QEMU and it worked. Real HW raspberry Pi is not applicable since it's just tutorial 2.
Pre-commit steps
./contributor_setup.shfollowed by./devtool ready_for_publishRubywithBundlerandNPMinstalled locally../devtool ready_for_publish_no_rustcan be used instead (faster).