Allow creating git config from strings (v2)

[DanielEScherzer]

@rustbot label +enhancement, "new bindings"

[DanielEScherzer]

Cross link #1225, #1226, #1227

[ehuss]

Sorry if I wasn't clear in the last PR, but I would prefer to not expose private APIs.

[DanielEScherzer]

Sorry if I wasn't clear in the last PR, but I would prefer to not expose private APIs.

I don't think this is a private API, since it is publicly documented in the reference, and it addresses a real use case https://github.com/rust-lang/thanks/blob/3600ac7559d242dda9f9c952f70450f3f91281e3/src/config.rs

If the issue is that it is listed under the "System Groups (Advanced)" part on https://libgit2.org/docs/reference/main/index.html, we already have bindings for functions from that section

• https://libgit2.org/docs/reference/main/sys/email/index.html

  git2-rs/libgit2-sys/lib.rs

  Line 4687 in 4de6b2e

  pub fn git_email_create_from_diff(

• https://libgit2.org/docs/reference/main/sys/errors/index.html

  git2-rs/libgit2-sys/lib.rs

  Lines 2541 to 2542 in 4de6b2e

  	pub fn git_error_clear();
  	pub fn git_error_set_str(error_class: c_int, string: *const c_char) -> c_int;

• https://libgit2.org/docs/reference/main/sys/mempack/index.html

  git2-rs/libgit2-sys/lib.rs

  Lines 4479 to 4481 in 4de6b2e

  	pub fn git_mempack_new(out: *mut *mut git_odb_backend) -> c_int;
  	pub fn git_mempack_reset(backend: *mut git_odb_backend) -> c_int;
  	pub fn git_mempack_dump(

• https://libgit2.org/docs/reference/main/sys/odb_backend/index.html -

  git2-rs/libgit2-sys/lib.rs

  Line 4409 in 4de6b2e

  pub fn git_odb_init_backend(odb: *mut git_odb_backend, version: c_uint) -> c_int;

• https://libgit2.org/docs/reference/main/sys/refdb_backend/index.html -

  git2-rs/libgit2-sys/lib.rs

  Lines 4490 to 4494 in 4de6b2e

  	pub fn git_refdb_backend_fs(
  	out: *mut *mut git_refdb_backend,
  	repo: *mut git_repository,
  	) -> c_int;
  	pub fn git_refdb_init_backend(backend: *mut git_refdb_backend, version: c_uint) -> c_int;

and probably more, I stopped looking after that

Do you want me to try and get some kind of upstream confirmation that this isn't a private API?