linker: Allow MSVC to use import libraries following the Meson/MinGW convention#123436
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 16, 2024
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
This PR implements support for
MsvcLinkerto use import libraries following Meson and the MinGW toolchain's naming convention. Meson follows thelibfoo.dll.anaming convention to disambiguate between static and import libraries.This support already existed for static libraries (see #100101), but not for dynamic libraries. The latter case was added by duplicating the logic in
native_libs::find_native_static_library, but a separate case was added inlink_dylib_by_namefor the Windows CRT libraries which must be handled by the linker itself.See for prerequisites #129366, #126094, and #128370.
All feedback is appreciated!
Fixes #122455
cc @sdroege @nirbheek