use download-ci-llvm=true in the default compiler config#129473
Merged
bors merged 1 commit intorust-lang:masterfrom Sep 10, 2024
Merged
use download-ci-llvm=true in the default compiler config#129473bors merged 1 commit intorust-lang:masterfrom
download-ci-llvm=true in the default compiler config#129473bors merged 1 commit intorust-lang:masterfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1ca2708 made it so that the
src/llvm-projectsubmodule has to be checkout fordownload-ci-llvm = "if-unchanged"to know if the submodule has been changed, but that is not required, if the submodule hasn't been checkout it cannot have been modified.This PR restore the previous behavior by only updating the submodule if it has already been checkout.This PR makes
download-ci-llvm = truecheck if CI llvm is available and make it the default for the compiler profile, as to prevent unnecessarily checking outsrc/llvm-projectwith"if-unchanged".r? @onur-ozkan