Use attributes for dangling_pointers_from_temporaries lint#132732
Merged
bors merged 6 commits intorust-lang:masterfrom Nov 20, 2024
gavincrawford:as_ptr_attribute
Merged
Use attributes for dangling_pointers_from_temporaries lint#132732bors merged 6 commits intorust-lang:masterfrom gavincrawford:as_ptr_attribute
dangling_pointers_from_temporaries lint#132732bors merged 6 commits intorust-lang:masterfrom
gavincrawford:as_ptr_attribute
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checking for dangling pointers by function name isn't ideal, and leaves out certain pointer-returning methods that don't follow the
as_ptrnaming convention. Using an attribute for this lint cleans things up and allows more thorough coverage of other methods, such asUnsafeCell::get().