Skip to content

install docs for each target in different directory#142478

Closed
Forist2034 wants to merge 1 commit intorust-lang:mainfrom
Forist2034:master
Closed

install docs for each target in different directory#142478
Forist2034 wants to merge 1 commit intorust-lang:mainfrom
Forist2034:master

Conversation

@Forist2034
Copy link
Copy Markdown

@Forist2034 Forist2034 commented Jun 13, 2025

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 13, 2025

r? @clubby789

rustbot has assigned @clubby789.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 13, 2025
@rustbot

This comment has been minimized.

@clubby789
Copy link
Copy Markdown
Contributor

Thanks!
@bors r+

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jun 18, 2025

📌 Commit 067a99b has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 18, 2025
Kobzol added a commit to Kobzol/rust that referenced this pull request Jun 19, 2025
install docs for each target in different directory

Solves rust-lang#140922
bors added a commit that referenced this pull request Jun 19, 2025
Rollup of 3 pull requests

Successful merges:

 - #142478 (install docs for each target in different directory)
 - #142629 (Add config builder for bootstrap tests)
 - #142699 (Update books)

Failed merges:

 - #142637 (Remove some glob imports from the type system)

r? `@ghost`
`@rustbot` modify labels: rollup
jhpratt added a commit to jhpratt/rust that referenced this pull request Jun 19, 2025
install docs for each target in different directory

Solves rust-lang#140922
bors added a commit that referenced this pull request Jun 19, 2025
Rollup of 10 pull requests

Successful merges:

 - #138291 (rewrite `optimize` attribute to use new attribute parsing infrastructure)
 - #141990 (Implement send_signal for unix child processes)
 - #142331 (Add `trim_prefix` and `trim_suffix` methods for both `slice` and `str` types.)
 - #142478 (install docs for each target in different directory)
 - #142571 (Reason about borrowed classes in CopyProp.)
 - #142668 (vec_deque/fmt/vec tests: remove static mut)
 - #142687 (Reduce uses of `hir_crate`.)
 - #142690 (expand: Remove some unnecessary generic parameters)
 - #142699 (Update books)
 - #142714 (add comment to `src/bootstrap/build.rs`)

Failed merges:

 - #142502 (rustdoc_json: improve handling of generic args)

r? `@ghost`
`@rustbot` modify labels: rollup
Kobzol added a commit to Kobzol/rust that referenced this pull request Jun 20, 2025
install docs for each target in different directory

Solves rust-lang#140922
bors added a commit that referenced this pull request Jun 20, 2025
Rollup of 11 pull requests

Successful merges:

 - #142478 (install docs for each target in different directory)
 - #142629 (Add config builder for bootstrap tests)
 - #142715 (correct template for `#[align]` attribute)
 - #142720 (De-dup common code from `ExternalCrate` methods)
 - #142736 (add issue template for rustdoc)
 - #142743 (rustc-dev-guide subtree update)
 - #142744 (Add a mailmap entry for y21)
 - #142758 (Make sure to rebuild rustdoc if `src/rustdoc-json-types` is changed)
 - #142764 (Convert `ilog(10)` to `ilog10()`)
 - #142767 (Some symbol and PathRoot cleanups)
 - #142769 (remove equivalent new method on context)

r? `@ghost`
`@rustbot` modify labels: rollup
@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented Jun 20, 2025

Probably caused this failure (#142781 (comment)).

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2025
@tgross35
Copy link
Copy Markdown
Contributor

Solves #140922

I changed this to "fixes"; "resolves" is on the autoclose list, but "solves" doesn't seem to be :) https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue#linking-a-pull-request-to-an-issue-using-a-keyword

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Jun 22, 2025

The Miri subtree was changed

cc @rust-lang/miri

@rust-log-analyzer

This comment has been minimized.

@Forist2034
Copy link
Copy Markdown
Author

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jun 22, 2025
@clubby789
Copy link
Copy Markdown
Contributor

@bors try

bors added a commit that referenced this pull request Jun 22, 2025
install docs for each target in different directory

Fixes: #140922

--

try-job: dist-i686-msvc
@bors
Copy link
Copy Markdown
Collaborator

bors commented Jun 22, 2025

⌛ Trying commit 1c2c23f with merge 23e695e...

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jun 22, 2025

☀️ Try build successful - checks-actions
Build commit: 23e695e (23e695e8f5c3b69ef164eec58222c3adb6e8ce60)

@clubby789
Copy link
Copy Markdown
Contributor

Can you squash these commits? r=me once that's done

@Forist2034
Copy link
Copy Markdown
Author

@bors r=clubby789

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jun 22, 2025

@Forist2034: 🔑 Insufficient privileges: Not in reviewers

@Forist2034
Copy link
Copy Markdown
Author

@clubby789 squashed these commits

@clubby789
Copy link
Copy Markdown
Contributor

@bors r+ rollup=never
(just in case there's any issues)

@bors
Copy link
Copy Markdown
Collaborator

bors commented Jun 23, 2025

📌 Commit 23518f7 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 23, 2025
@Kobzol
Copy link
Copy Markdown
Member

Kobzol commented Jun 23, 2025

@Mark-Simulacrum This changes the directory layout of the docs component. Do we promise any kind of stability for these paths?

@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented Jun 24, 2025

At the very least rustup doc will need to be updated for the new path.

@bjorn3
Copy link
Copy Markdown
Member

bjorn3 commented Jun 24, 2025

And I think whatever code uploads the docs to docs.rust-lang.org will need to be updated too.

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 24, 2025
@Forist2034
Copy link
Copy Markdown
Author

Should i create an issue or pr on rustup and rust-analyzer repo?

@JohnCSimon
Copy link
Copy Markdown
Member

Should i create an issue or pr on rustup and rust-analyzer repo?

Triage:

@bjorn3 can you help @Forist2034 on this?

@bors
Copy link
Copy Markdown
Collaborator

bors commented Aug 11, 2025

☔ The latest upstream changes (presumably #145011) made this pull request unmergeable. Please resolve the merge conflicts.

@Dylan-DPC
Copy link
Copy Markdown
Member

@Forist2034 any updates of this? if you have created an issue on rustup and r-a repos kindly link them here so we can track for progress and also mark it as s-blocked. Thanks

@Dylan-DPC
Copy link
Copy Markdown
Member

Closing this as inactive. Feel free to reöpen this pr or create a new pr if you get the time to work on this. Thanks

@Dylan-DPC Dylan-DPC closed this Apr 3, 2026
@rustbot rustbot removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Apr 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

make install only keeps docs of last target for multi-target builds

10 participants