resolve: Split extern prelude into two scopes#144793
Merged
bors merged 3 commits intorust-lang:masterfrom Aug 14, 2025
Merged
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One scope for
extern crateitems and another for--externoptions, with the former shadowing the latter.If in a single scope some things can overwrite other things, especially with ad hoc restrictions like
MacroExpandedExternCrateCannotShadowExternArguments, then it's not really a single scope.So this PR splits
Scope::ExternPreludeinto two cleaner scopes.This is similar to how #144131 splits module scope into two scopes for globs and non-globs, but simpler.