Remove feature(string_deref_patterns)#150530
Merged
bors merged 1 commit intorust-lang:mainfrom Dec 31, 2025
Merged
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The older
string_deref_patternsfeature has been superseded by the newer and more generalderef_patternsfeature. Removing string-deref-patterns allows us to get rid of a few tricky special cases in match lowering, which are different from the special cases used by deref-patterns.The handful of existing tests for
string_deref_patternshave been migrated to usederef_patternsinstead. Current nightly users of the older feature should hopefully be able to migrate to the newer feature without too much trouble.Note that
deref_patternsis currently marked as an “incomplete” feature, because it doesn't have an accepted RFC. Butstring_deref_patternsdoesn't appear to have ever had an accepted RFC either, so arguably it should have been marked incomplete too.#![feature(string_deref_patterns)]?