Remove two more flaky assertions from oneshot tests#152878
Merged
rust-bors[bot] merged 1 commit intorust-lang:mainfrom Feb 21, 2026
Merged
Remove two more flaky assertions from oneshot tests#152878rust-bors[bot] merged 1 commit intorust-lang:mainfrom
oneshot tests#152878rust-bors[bot] merged 1 commit intorust-lang:mainfrom
Conversation
Loading
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These elapsed-time-upper-bound assertions are inherently flaky in CI, because CI runners will sometimes starve individual threads for a surprisingly long time, so the assertions can fail even if nothing went wrong.
Similar changes for other flaky
oneshottests:oneshot::recv_timeout_before_send#152145oneshot::send_before_recv_timeout#152648Example flaky failure:
enum DepKind. #152747 (comment)