Cleanup unused diagnostic emission methods#153452
Merged
rust-bors[bot] merged 11 commits intorust-lang:mainfrom Mar 6, 2026
Merged
Cleanup unused diagnostic emission methods#153452rust-bors[bot] merged 11 commits intorust-lang:mainfrom
rust-bors[bot] merged 11 commits intorust-lang:mainfrom
Conversation
Collaborator
|
HIR ty lowering was modified cc @fmease |
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
JonathanBrouwer
requested changes
Mar 5, 2026
9182eab to
9dfb21c
Compare
This comment has been minimized.
This comment has been minimized.
9dfb21c to
c98094b
Compare
Collaborator
|
Some changes occurred in src/tools/clippy cc @rust-lang/clippy |
Member
Author
|
PR is not ready, we need to figure out why the tracking is currently broken in clippy: You can run this (specific) test with: |
This comment has been minimized.
This comment has been minimized.
6ab577a to
6c0ae27
Compare
6c0ae27 to
8d96e60
Compare
Contributor
|
r=me if ci green & you agree with my commit |
This comment has been minimized.
This comment has been minimized.
Member
Author
|
@bors r=JonathanBrouwer rollup |
Contributor
3 tasks
rust-bors bot
pushed a commit
that referenced
this pull request
Mar 6, 2026
…uwer Rollup of 14 pull requests Successful merges: - #153466 (`rust-analyzer` subtree update) - #151280 (Fix incorrect trailing comma suggested in no_accessible_fields) - #152593 (Box in `ValTreeKind::Branch(Box<[I::Const]>)` changed to `List`) - #153174 (std: add wasm64 to sync::Once and thread_parking atomics cfg guards) - #153485 (libcore float tests: replace macro shadowing by const-compatible macro) - #153495 (Fix ICE in `offset_of!` error recovery) - #152040 (Do not emit ConstEvaluatable goals if type-const) - #152741 (Suppress invalid suggestions in destructuring assignment) - #153189 (refactor: move `check_align` to `parse_alignment`) - #153230 (Roll rustfmt reviewers for in-tree rustfmt) - #153445 (Consider try blocks as block-like for overflowed expr) - #153452 (Cleanup unused diagnostic emission methods) - #153476 (bootstrap.py: fix typo "parallle") - #153483 (Preserve parentheses around `Fn` trait bounds in pretty printer)
rust-timer
added a commit
that referenced
this pull request
Mar 6, 2026
Rollup merge of #153452 - GuillaumeGomez:migrate-diag, r=JonathanBrouwer Cleanup unused diagnostic emission methods Part of #153099. To remove `lint_level`, we need to remove all functions calling it. One of them is `TyCtxt::node_span_lint`, so removing it. r? @JonathanBrouwer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #153099.
To remove
lint_level, we need to remove all functions calling it. One of them isTyCtxt::node_span_lint, so removing it.r? @JonathanBrouwer