Skip to content

Update a bunch of dependencies to reduce windows-sys duplication#155444

Merged
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
bjorn3:update_deps
Apr 19, 2026
Merged

Update a bunch of dependencies to reduce windows-sys duplication#155444
rust-bors[bot] merged 2 commits intorust-lang:mainfrom
bjorn3:update_deps

Conversation

@bjorn3
Copy link
Copy Markdown
Member

@bjorn3 bjorn3 commented Apr 17, 2026

This gets rid of windows-sys 0.60 and with the exception of curl and stacker it gets rid of windows-sys 0.59. For stacker getting rid of windows-sys 0.59 is blocked on rust-lang/stacker#145 and #155438.

@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 17, 2026

Some changes occurred in src/tools/compiletest

cc @jieyouxu

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@rustbot rustbot added the A-compiletest Area: The compiletest test runner label Apr 17, 2026
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team. labels Apr 17, 2026
@rustbot
Copy link
Copy Markdown
Collaborator

rustbot commented Apr 17, 2026

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: @Mark-Simulacrum

@jieyouxu jieyouxu self-assigned this Apr 17, 2026
Copy link
Copy Markdown
Member

@jieyouxu jieyouxu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Looked at https://github.com/Seeker14491/opener/blob/HEAD/CHANGELOG.md#084---2026-01-25 just in case, but I don't think anything is significant there.

r? me @bors r+ rollup=never (just in case)

View changes since this review

@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 18, 2026

📌 Commit 57966e9 has been approved by jieyouxu

It is now in the queue for this repository.

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2026
@rust-bors

This comment has been minimized.

@rust-bors rust-bors Bot added merged-by-bors This PR was explicitly merged by bors. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 19, 2026
@rust-bors
Copy link
Copy Markdown
Contributor

rust-bors Bot commented Apr 19, 2026

☀️ Test successful - CI
Approved by: jieyouxu
Duration: 3h 17m 11s
Pushing 22cc674 to main...

@rust-bors rust-bors Bot merged commit 22cc674 into rust-lang:main Apr 19, 2026
12 checks passed
@rustbot rustbot added this to the 1.97.0 milestone Apr 19, 2026
@github-actions
Copy link
Copy Markdown
Contributor

What is this? This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing ec2d669 (parent) -> 22cc674 (this PR)

Test differences

Show 3 test diffs

3 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 22cc6747b18b3a6738e98b06676fd91f1756b33a --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

  1. x86_64-msvc-ext1: 1h 41m -> 2h 19m (+37.6%)
  2. test-various: 1h 35m -> 2h 10m (+36.3%)
  3. dist-apple-various: 2h 10m -> 1h 28m (-32.1%)
  4. x86_64-msvc-2: 1h 56m -> 2h 32m (+31.0%)
  5. x86_64-gnu-debug: 1h 27m -> 1h 54m (+30.5%)
  6. x86_64-gnu-miri: 1h 27m -> 1h 4m (-26.4%)
  7. x86_64-msvc-ext3: 1h 50m -> 1h 22m (-25.3%)
  8. dist-x86_64-musl: 1h 45m -> 2h 8m (+21.5%)
  9. dist-android: 23m 34s -> 28m 26s (+20.6%)
  10. pr-check-2: 31m 27s -> 37m 45s (+20.0%)
How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

@bjorn3 bjorn3 deleted the update_deps branch April 19, 2026 16:26
@rust-timer
Copy link
Copy Markdown
Collaborator

Finished benchmarking commit (22cc674): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This perf run didn't have relevant results for this metric.

Max RSS (memory usage)

Results (primary -2.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-2.8% [-2.8%, -2.8%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.8% [-2.8%, -2.8%] 1

Cycles

Results (primary 3.4%, secondary -2.2%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

mean range count
Regressions ❌
(primary)
3.4% [3.3%, 3.5%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.2% [-2.2%, -2.2%] 1
All ❌✅ (primary) 3.4% [3.3%, 3.5%] 2

Binary size

This perf run didn't have relevant results for this metric.

Bootstrap: 490.129s -> 492.081s (0.40%)
Artifact size: 394.32 MiB -> 394.29 MiB (-0.01%)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-compiletest Area: The compiletest test runner A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-clippy Relevant to the Clippy team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants