experiment: Support NonZero<u16> in ToSocketAddr impls#155983
Draft
edward-shen wants to merge 1 commit intorust-lang:mainfrom
Draft
experiment: Support NonZero<u16> in ToSocketAddr impls#155983edward-shen wants to merge 1 commit intorust-lang:mainfrom
edward-shen wants to merge 1 commit intorust-lang:mainfrom
Conversation
rustbot
added
S-waiting-on-author
Contributor
Author
|
@bors try |
Contributor
|
@edward-shen: 🔑 Insufficient privileges: not in try users |
This comment has been minimized.
This comment has been minimized.
All tuple From implementations for ToSocketAddr currently only accept a u16 as the port number. This results in a small ergonomics penalty for users that parse out a NonZero port number from the program's arguments. This adds a small set of implementations that copies any tuple implementation on ToSocketAddr that takes in a u16 as a port and instead accepts a NonZero<u16>. For consistency, a From<(I, NonZeroU16)> implementation for SocketAddr was also implemented.
edward-shen
force-pushed
the
edward-shen/nonzero-port-impls
branch
from
e8a90dd to
00f08d0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a draft PR for a crater run requested in rust-lang/libs-team#781.
All tuple
Fromimplementations forToSocketAddrcurrently only accept au16as the port number. This results in a small ergonomics penalty for users that parse out aNonZeroport number from the program's arguments.This adds a small set of implementations that copies any tuple implementation on
ToSocketAddrthat takes in a u16 as a port and instead accepts aNonZero<u16>.For consistency, a
From<(I, NonZeroU16)>implementation forSocketAddrwas also implemented.As far as I can tell, these implementations will be insta-stable.